This repository was archived by the owner on Dec 5, 2025. It is now read-only.
fix: support dual-stack ipv4 and ipv6 machines#32
Closed
vlsi wants to merge 1 commit intoNetcracker:mainfrom
Closed
fix: support dual-stack ipv4 and ipv6 machines#32vlsi wants to merge 1 commit intoNetcracker:mainfrom
vlsi wants to merge 1 commit intoNetcracker:mainfrom
Conversation
Previously, LISTEN_ADDR was set to hostname -i which might return
multiple ip addresses separated with space, which is not compatible with
cases like ${LISTEN_ADDR}:5432
When listen on all the addresses is needed, we'd better use *:5432
Author
|
It might be better to remove the variable |
Author
|
Closing in favour of #33. Here's a PR for the removal of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, LISTEN_ADDR was set to hostname -i which might return multiple ip addresses separated with space, which is not compatible with cases like ${LISTEN_ADDR}:5432
When listen on all the addresses is needed, we'd better use *:5432